refactor(producer): extract HDR compositor from renderOrchestrator#1419
Closed
miguel-heygen wants to merge 1 commit into
Closed
refactor(producer): extract HDR compositor from renderOrchestrator#1419miguel-heygen wants to merge 1 commit into
miguel-heygen wants to merge 1 commit into
Conversation
Move ~700 LOC of HDR compositing primitives (countNonZeroAlpha, countNonZeroRgb48, cropRgb48le, HdrVideoFrameSource, closeHdrVideoFrameSource, blitHdrVideoLayer, HdrImageBuffer, blitHdrImageLayer, CompositeTransfer, shouldUseLayeredComposite, resolveCompositeTransfer, HdrCompositeContext, compositeHdrFrame, HdrTransitionMeta, TransitionRange) into a dedicated hdrCompositor.ts module. Remove backward-compat re-exports from renderOrchestrator (hdrPerf, captureCost, shared) and rewire all import sites to the authoritative source modules.
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract ~700 LOC of HDR compositing types and functions from the 2,474-LOC
renderOrchestrator.tsinto a newhdrCompositor.tsmodule. Remove backward-compat re-exports from hdrPerf, captureCost, and shared. Rewire all 8 internal import sites.This is a pure code move — no logic changes. Reviewer can verify by confirming the same code appears in the new file as was removed from the old one.
renderOrchestrator.tsdrops to 1,769 LOC.1,473 LOC (723 insertions, 750 deletions — code move)
Stack: 3/5